Skip to content

Clean Code for apitools/org.eclipse.pde.api.tools.ui#1697

Merged
laeubi merged 1 commit intomasterfrom
clean-code/apitools/org.eclipse.pde.api.tools.ui
Mar 25, 2025
Merged

Clean Code for apitools/org.eclipse.pde.api.tools.ui#1697
laeubi merged 1 commit intomasterfrom
clean-code/apitools/org.eclipse.pde.api.tools.ui

Conversation

@eclipse-pde-bot
Copy link
Contributor

@eclipse-pde-bot eclipse-pde-bot commented Mar 22, 2025

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@github-actions
Copy link

github-actions bot commented Mar 22, 2025 •
edited
Loading

Test Results

   279 files   -     2     279 suites   - 2   46m 13s ⏱️ + 3m 12s
 3 608 tests ±    0   3 531 ✅ ±    0   76 💤 ±0  1 ❌ ±0 
10 822 runs  +2 498  10 619 ✅ +2 503  202 💤  - 5  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 8f30979. ± Comparison against base commit 5d4fd66.

♻️ This comment has been updated with latest results.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/apitools/org.eclipse.pde.api.tools.ui branch from f5430b7 to 8f30979 Compare March 23, 2025 02:36
@laeubi laeubi merged commit 60ce2fc into master Mar 25, 2025
16 of 18 checks passed
@akurtakov akurtakov deleted the clean-code/apitools/org.eclipse.pde.api.tools.ui branch March 25, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eclipse-pde-bot @laeubi